Ensure assert_eq_unordered panics display the line on which they were called - #3
Open
uckelman wants to merge 1 commit into
Open
Ensure assert_eq_unordered panics display the line on which they were called#3uckelman wants to merge 1 commit into
uckelman wants to merge 1 commit into
Conversation
a failing assert_eq_unordered* macro backtrace will list the line where the macro was called, just like assert_eq! does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assert_eq_unorderedmacros display the line wherepanic!is called inside theassert_unorderedcrate. This isn't the most helpful information when you have several unordered assertions that could be failing.This PR adds
#[track_caller]to functions called on the way to panics; this way, a failingassert_eq_unorderedmacro backtrace will list the line where the macro was called, just likeassert_eq!does.