http2: don't throw when destroying socket proxy#64427
Open
mcollina wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Calling destroy() on the http2session.socket proxy now destroys the session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION. Refs: nodejs/undici#5525 Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
http2-socket-proxy-destroy
branch
from
27433a8 to
fa57b72
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64427 +/- ##
=======================================
Coverage 90.24% 90.25%
=======================================
Files 741 741
Lines 241384 241384
Branches 45480 45484 +4
=======================================
+ Hits 217844 217851 +7
+ Misses 15097 15088 -9
- Partials 8443 8445 +2
🚀 New features to boost your workflow:
|
efekrskl
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
destroy()on thehttp2session.socketproxy now destroys the session instead of throwingERR_HTTP2_NO_SOCKET_MANIPULATION, matching the streams contract thatdestroy()never throws (root cause behind nodejs/undici#5525).