Development guide: private and public API section - #303
Open
arut wants to merge 1 commit into
Open
Conversation
pluknet
reviewed
Aug 6, 2026
| </para> | ||
|
|
||
| <para> | ||
| Accessing nginx data that is defined in C source files and not exported |
Collaborator
There was a problem hiding this comment.
"data" may need clarification
|
|
||
| <para> | ||
| Accessing nginx data that is defined in C source files and not exported | ||
| through header files is strongly discouraged, as is copying standard nginx |
Collaborator
Author
There was a problem hiding this comment.
I consulted AI for this.
| Accessing nginx data that is defined in C source files and not exported | ||
| through header files is strongly discouraged, as is copying standard nginx | ||
| functions in order to alter their behavior. | ||
| Such code is fragile: it may become binary incompatible with a later nginx |
Collaborator
Author
There was a problem hiding this comment.
Again, AI helped me to phrase this correctly. Using "approach" invalidates the later part of the sentence.
| Accessing nginx data that is defined in C source files and not exported | ||
| through header files is strongly discouraged, as is copying standard nginx | ||
| functions in order to alter their behavior. | ||
| Such code is fragile: it may become binary incompatible with a later nginx |
Collaborator
There was a problem hiding this comment.
suggestion:
the resulting binary may become incompatible when compiling against later nginx versions
Collaborator
Author
There was a problem hiding this comment.
Looks like a complication.
arut
force-pushed
the
public-private-api
branch
2 times, most recently
from
August 7, 2026 15:08
765531a to
a799b8c
Compare
arut
force-pushed
the
public-private-api
branch
from
August 7, 2026 15:25
a799b8c to
3ec3824
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.