Tests: Cache-Control directive matching at token boundaries - #85
Open
VadimZhestikov wants to merge 3 commits into
Open
Tests: Cache-Control directive matching at token boundaries#85VadimZhestikov wants to merge 3 commits into
VadimZhestikov wants to merge 3 commits into
Conversation
2 tasks
Extension directives that merely contain a standard directive name as a substring, such as "x-max-age=" or "foo-s-maxage=", must not be treated as the standard freshness directive and must not make a response cacheable. The tests are marked TODO until the corresponding change is released.
An option that merely contains "close" or "keep-alive" as a substring must not select the client connection type, nor prevent an upstream connection from being reused.
VadimZhestikov
force-pushed
the
test/cache-control-token-boundary
branch
from
August 5, 2026 18:08
8bd0755 to
efe240d
Compare
A tab may separate list elements, both after the colon and after a comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds cases to
proxy_cache_control.tverifying that extension directives which merely contain a standard directive name as a substring (x-max-age=,foo-s-maxage=) are not treated as the standard freshness directive and do not make a response cacheable.Marked TODO until the corresponding code change is released.
Code PR: nginx/nginx#1577