Tests: QUIC STREAM_DATA_BLOCKED and DATA_BLOCKED frames - #76
Draft
VadimZhestikov wants to merge 1 commit into
Draft
Tests: QUIC STREAM_DATA_BLOCKED and DATA_BLOCKED frames#76VadimZhestikov wants to merge 1 commit into
VadimZhestikov wants to merge 1 commit into
Conversation
The tests drive the server into the stream-level and connection-level blocked states using small advertised flow-control windows, check that the corresponding frames are sent with the expected limits, that a new frame is sent after the limit is raised and exhausted again, and that the transfer completes once enough credit is granted. Test::Nginx::HTTP3 parse_frames() is extended to parse both frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional tests for nginx/nginx#1558 (QUIC: send DATA_BLOCKED and STREAM_DATA_BLOCKED frames; a rework of nginx/nginx#1492).
h3_stream_data_blocked.tdrives the server into the stream-level and connection-level blocked states using small advertised flow-control windows (transport parametersinitial_max_stream_data_bidi_local/initial_max_data), then checks that:STREAM_DATA_BLOCKEDis sent with the expected stream id and limit;DATA_BLOCKED.Test::Nginx::HTTP3::parse_frames()is extended to parse both frame types (0x14, 0x15), which previously fell through unparsed.The tests fail against current nginx master (no frames are ever sent) and pass against the nginx/nginx#1558 branch; the full test suite passes with the modified library.