Tests: gzip 410 Gone responses. - #65
Open
ylw510 wants to merge 1 commit into
Open
Conversation
Verify that the gzip filter compresses 410 responses when enabled.
Author
|
Related PR: nginx/nginx#1466 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests: gzip 410 Gone responses
Proposed changes
Add test coverage for gzip compression of 410 Gone responses.
The gzip filter in nginx only compresses 200, 403, and 404 responses today. A companion change in nginx/nginx adds 410 to that set (see nginx/nginx#1452).
This PR extends
gzip.twith:/gonelocation that returns410with a 64-bytetext/plainbody410 gone— response status is 410 Gonegzip 410— response includesContent-Encoding: gzipgzip 410 content— gzipped body decodes to the expected payloadRelated issue: nginx/nginx#1452
Companion nginx PR: (add link after opening, e.g. https://github.com/nginx/nginx/pull/XXXX)
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md). (not applicable — test-only change)How to run
The new 410-related subtests require an nginx binary that includes the gzip 410 change from the companion PR.