ci: Switch to GitHub actions#20
Merged
Merged
Conversation
This will allow users to create their own configs overwriting e.g. `editorUrl` parameter in `phpstan.neon`. https://phpstan.org/config-reference#config-file https://phpstan.org/config-reference#clickable-editor-url Add the old name to `.gitignore` to avoid accidentally commiting it.
To allow running PHPStan without extra arguments. Picked the values used by Travis CI config.
For convenience.
`endLine` property was dropped: nette/forms@c494415 Let’s resort to duck typing for now so that we do not depend on a too-new version.
Fixes PHPStan errors – thes could actually happen when the form contains a `Nette\Forms\Control` subclass that is not an instance of `BaseControl`. Most controls will satisfy it but we do not want to limit ourselves to that with `instanceof` check since we also want to support third-party controls (e.g. those using `Nextras\FormComponents\Fragments\Traits\BaseControlTrait`). Hence the duck typing.
We only have PHPStan but that is better than nothing.
Will be needed to satisfy PHPStan.
Member
|
👏 |
Contributor
Author
|
Fixing the breakage in #21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only have PHPStan but that is better than nothing.
Would be nice to release a new version after merging this.