Skip to content

fix(call): reduce redundant flags update - #18853

Open
Antreesy wants to merge 2 commits into
mainfrom
fix/noid/call-flags-update
Open

fix(call): reduce redundant flags update#18853
Antreesy wants to merge 2 commits into
mainfrom
fix/noid/call-flags-update

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

β˜‘οΈ Resolves

  • do not set redundant requests on input device change
    -Β  client briefly stops previous track and requesting new one. During that window updateCallFlags might be triggered, as if user has completely disabled the camera and back
    • add a grace period of 1 second if flags bitmask goes in direction of removing bits
      fix last frozen frame leaking after device change
    • when video track reassigned (change camera), connection shortly abrupts, call flags with no video being sent twice, and on reconnect video tile still holds reference to previos stream object (frozen last frame).
    • re-attach of video stream fixes that

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

🏚️ Before 🏑 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy added 2 commits July 29, 2026 12:35
-  client briefly stops previous track and requesting new one. During that window `updateCallFlags` might be triggered, as if user has completely disabled the camera and back
- add a grace period of 1 second if flags bitmask goes in direction of removing bits

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- when video track reassigned (change camera), connection shortly abrupts,
  call flags with no video being sent twice, and on reconnect video tile
  still holds reference to previos stream object (frozen last frame).
- re-attach of video stream fixes that

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the β›… Next Major (35) milestone Jul 29, 2026
@Antreesy
Antreesy requested a review from DorraJaouad July 29, 2026 10:41
@Antreesy Antreesy self-assigned this Jul 29, 2026
@Antreesy Antreesy added bug feature: WebRTC 🚑 WebRTC connection between browsers and/or mobile clients feature: frontend πŸ–ŒοΈ "Web UI" client feature: call πŸ“Ή Voice and video calls labels Jul 29, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits bug feature: call πŸ“Ή Voice and video calls feature: frontend πŸ–ŒοΈ "Web UI" client feature: WebRTC 🚑 WebRTC connection between browsers and/or mobile clients

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants