Skip to content

fix(call): reapply videoConstrainer on source change - #18737

Open
Antreesy wants to merge 1 commit into
mainfrom
fix/8815/video-constraints-p2
Open

fix(call): reapply videoConstrainer on source change#18737
Antreesy wants to merge 1 commit into
mainfrom
fix/8815/video-constraints-p2

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

β˜‘οΈ Resolves

  • Fix Aspect-ratio for video-tracks is not consideredΒ #8815
  • Issue is actually in two parts:
    • 1 - 16:9 is constrained to 4:3 - was due to strict constraints, changed before. UI for local video might still be locked to 4:3 aspect ration, but full video is translate - there are other isues ope for that topic
    • 2 - constraints are not re-applied after source change / camera state change -> new video stream goes as-is - fixed with this PR

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

To test - try fix/noid/video-constraints-p1 base branch - logger is in place, but nothing triggers applyConstraints after initialized first time.

Before: only first resolution will be seen
After:
2026-07-22_11h04_06

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

- after swapping the camera, it can have different resolution available - constraints should be reapplied, to not introduce silent bugs

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the β›… Next Major (35) milestone Jul 22, 2026
@Antreesy
Antreesy requested review from ShGKme and danxuliu July 22, 2026 10:06
@Antreesy Antreesy self-assigned this Jul 22, 2026
Base automatically changed from fix/noid/video-constraints-p1 to main July 22, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant