fix(recording): support long room tokens for uploads - #18491
fix(recording): support long room tokens for uploads#18491pollychen-lab wants to merge 2 commits into
Conversation
Signed-off-by: Polly Labs <pollychen.lab@gmail.com>
|
Signed-off-by: Polly Labs <pollychen.lab@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Keep recording upload app-config keys within Nextcloud's 64-character limit when a conversation uses a long room token.
Root cause
The upload key combines the
recupload/prefix, room token, separator, and a 40-character SHA-1 filename hash. A maximum-length 30-character room token produces an 81-character key, causing chunked upload setup to fail.Changes
At the maximum token length, the filename hash retains 23 hexadecimal characters (92 bits).
Validation
git diff --checkFixes #18458