[stable8.3] fix(settings): read social sync initial state as boolean - #5621
Draft
backportbot[bot] wants to merge 2 commits into
Draft
[stable8.3] fix(settings): read social sync initial state as boolean#5621backportbot[bot] wants to merge 2 commits into
backportbot[bot] wants to merge 2 commits into
Conversation
Since babe45a the PageController provides allowSocialSync and enableSocialSync as booleans, but ContactsSettings.vue still compared them with the strings 'yes'/'no'. Both comparisons therefore always evaluated to true: the 'Update avatars from social media' switch always appeared enabled regardless of the stored setting. Also put the unused allowSocialSync state back to work by hiding the switch when the administrator has disabled social sync, matching the behaviour before the settings dialog refactorings. AdminSettings.vue is intentionally left unchanged: its initial state comes from lib/Settings/AdminSettings.php, which still provides the raw string app values, so the string comparison is correct there. Resolves #5561 Assisted-by: Claude:claude-fable-5 Signed-off-by: MiMoHo <37556964+MiMoHo@users.noreply.github.com> Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
fix: unify `allowSocialSync` frontend type Signed-off-by: Hamza <hamzamahjoubi221@gmail.com> [skip ci]
backportbot
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5566
Warning, This backport's changes differ from the original and might be incomplete鈿狅笍
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.