improve memory footprint for read operations - #2102
Open
alperozturk96 wants to merge 1 commit into
Open
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces repeated WebDAV response-array access and attempts to improve memory behavior when parsing folder listings (regular files, trashbin, and versions) in the legacy owncloud remote operations.
Changes:
- Cache
remoteData.getResponses()into a localMultiStatusResponse[]to avoid repeated calls during parsing. - Pre-size
ArrayListinstances based on the number of WebDAV responses to reduce resizing overhead. - Add an
OutOfMemoryErrorcatch inReadFolderRemoteOperationto return a failure instead of crashing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| library/src/main/java/com/owncloud/android/lib/resources/trashbin/ReadTrashbinFolderRemoteOperation.java | Cache responses array and pre-size result list while iterating trashbin entries. |
| library/src/main/java/com/owncloud/android/lib/resources/files/ReadFolderRemoteOperation.java | Cache responses array, pre-size list, and add an OutOfMemoryError catch during folder reads. |
| library/src/main/java/com/owncloud/android/lib/resources/files/ReadFileVersionsRemoteOperation.java | Cache responses array and pre-size versions list while iterating version entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private void readData(MultiStatus remoteData, OwnCloudClient client) { | ||
| folderAndFiles = new ArrayList<>(); | ||
| MultiStatusResponse[] responses = remoteData.getResponses(); | ||
| folderAndFiles = new ArrayList<>(responses.length); |
Comment on lines
+84
to
+87
| } catch (OutOfMemoryError e) { | ||
| mFolderAndFiles = null; | ||
| result = new RemoteOperationResult( | ||
| new Exception("Not enough memory to read the contents of " + mRemotePath, e)); |
| private void readData(MultiStatus remoteData, OwnCloudClient client) { | ||
| versions = new ArrayList<>(); | ||
| MultiStatusResponse[] responses = remoteData.getResponses(); | ||
| versions = new ArrayList<>(responses.length); |
Collaborator
|
stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/2102-IT-stable22-13-53/debug/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
remoteData.getResponses();