[REF] Update SessionPath -> SessionFilePath#242
Open
surchs wants to merge 1 commit into
Open
Conversation
Reviewer's Guide by SourceryThis PR implements a column name change from 'SessionPath' to 'SessionFilePath' across the codebase. The change is straightforward, involving updates to column names in DataFrame operations, test assertions, and file path handling functions. Class diagram for DataFrame column updateclassDiagram
class DataFrame {
+DatasetID
+SubjectID
+SessionID
+SessionFilePath
}
note for DataFrame "Updated column name from 'SessionPath' to 'SessionFilePath'"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @surchs - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please investigate why you cannot run the test suite locally and fix that issue. Being able to run and verify tests locally is important for maintaining code quality, even for straightforward changes like this one.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I could not get the test suite to run locally, this seems related / identical to e.g.: https://github.com/neurodatascience/cohort_creator/actions/runs/11661670644/job/32466434137#step:8:29
Summary by Sourcery
Rename 'SessionPath' to 'SessionFilePath' throughout the codebase to improve clarity and consistency, and update related test cases accordingly.
Enhancements:
Tests: