Skip to content

chore(workflows): delete leftover pr-validation.yml - #192

Merged
ciotlosm merged 4 commits into
mainfrom
chore/delete-pr-validation-leftover
Jul 11, 2026
Merged

chore(workflows): delete leftover pr-validation.yml#192
ciotlosm merged 4 commits into
mainfrom
chore/delete-pr-validation-leftover

Conversation

@ciotlosm

Copy link
Copy Markdown
Member

Summary

PR #188 renamed pr-validation.yml -> pr-check.yml and dropped the auto-bump job, but the old file was never deleted. This PR removes the leftover.

What was in the old file

  • name: "PR Validation" (not the [<type>] <subject> (<trigger>) standard)
  • An auto-bump job that called n3ary/actions/.github/actions/version-bump@v22
  • contents: write permission for the auto-bump to push commits
  • A direct reference to pr-validation.yml@v22, superseded by pr-check.yml@v23

Why this is a no-op

The old file's only non-shared job was the auto-bump job, which is no longer needed (n3ary/release-bot handles version bumps on PR merge). Branch protection doesn't reference the workflow by filename - it references checks by name, and pr-check.yml (the new file) already provides the shared validation that was the main reason for keeping the file.

Refs: n3ary/standards#22

ciotlosm added 2 commits July 11, 2026 16:10
PR #188 renamed pr-validation.yml -> pr-check.yml and dropped the
auto-bump job, but the old file was never deleted. This commit
removes the leftover.

The old file had:
- name: "PR Validation" (not the [<type>] standard)
- an auto-bump job that called n3ary/actions/.github/actions/version-bump@v22
- contents: write permission for the auto-bump to push commits
- a dependency on a workflow (pr-validation.yml@v22) that has
  since been superseded by pr-check.yml@v23

pr-check.yml covers the same triggers (pull_request) and is the
canonical PR check workflow for this repo. The old file's
removal is a no-op for branch protection (no consumer references
its name: "PR Validation" check explicitly - the only check it
contributed was the auto-bump job, which we no longer need).

Refs: n3ary/standards#22
@ciotlosm
ciotlosm enabled auto-merge (squash) July 11, 2026 13:15
@ciotlosm ciotlosm closed this Jul 11, 2026
auto-merge was automatically disabled July 11, 2026 13:26

Pull request was closed

@ciotlosm ciotlosm reopened this Jul 11, 2026
@ciotlosm
ciotlosm merged commit aad7555 into main Jul 11, 2026
3 checks passed
@ciotlosm
ciotlosm deleted the chore/delete-pr-validation-leftover branch July 11, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant