Fix parallel test suites freezing instead of reporting a crash - #95
Closed
mvrahden wants to merge 2 commits into
Closed
Fix parallel test suites freezing instead of reporting a crash#95mvrahden wants to merge 2 commits into
mvrahden wants to merge 2 commits into
Conversation
mvrahden
changed the title
Owner
Author
|
Superseded by #96, which now targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a test crashed inside a suite that runs its tests in parallel, the whole run
froze. Nothing was reported, and it stayed stuck until the global ten-minute
timeout killed it. So instead of seeing what actually broke, you waited ten
minutes and got a timeout.
The cause was in the code we generate for those suites: the suite's cleanup step
waited for work that, after a crash, could never finish. Removing that wait lets
the crash be reported straight away.
A second problem turned up in the same place. Suite cleanup was being handed an
already-expired deadline, so any cleanup that relied on one failed instantly.
It now gets a valid one, and the timeout you configure actually applies.
Added tests that reproduce the original freeze and confirm it now fails fast
instead.