Skip to content

App start. Added a notification that the current page was changed - #247

Open
Eism wants to merge 2 commits into
musescore:mainfrom
Eism:app_start_fix
Open

App start. Added a notification that the current page was changed#247
Eism wants to merge 2 commits into
musescore:mainfrom
Eism:app_start_fix

Conversation

@Eism

@Eism Eism commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

This notification is need to close the splash screen only when the content is ready.

  • covered one more case with closing the splash screen

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ad63420c-3db3-4eb2-a3f0-d15870320561

📥 Commits

Reviewing files that changed from the base of the PR and between 93b38f6 and 83508bc.

📒 Files selected for processing (8)
  • framework/dockwindow/idockwindow.h
  • framework/dockwindow/qml/Muse/Dock/dockwindow.cpp
  • framework/dockwindow/qml/Muse/Dock/dockwindow.h
  • framework/dockwindow_v2/idockwindow.h
  • framework/dockwindow_v2/qml/Muse/Dock/dockwindow.cpp
  • framework/dockwindow_v2/qml/Muse/Dock/dockwindow.h
  • framework/global/iapplication.h
  • framework/ui/internal/guiapplication.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change adds currentPageChanged() to both dock-window interfaces and implementations. Each implementation stores a notification channel and emits it after loading a new current page. The application interface adds a default closeSplash() hook. startupScenario calls this hook when the main window fails to load.

Merge Risk: ⚪ Minimal · up to 83508

This localized startup notification change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the motivation but omits the required issue reference, checklist, and other template sections. Complete the template with the issue reference, motivation details, checklist responses, and build configuration as applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding a notification for current-page changes.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant