Skip to content

GTFS-RT > Trip Updates > never ignore CANCELLED trips because too much into the future #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmathieum merged 2 commits into from
Aug 1, 2026
Merged

GTFS-RT > Trip Updates > never ignore CANCELLED trips because too much into the future #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a26ebbf
GTFS-RT > Trip Updates > never ignore CANCELLED trips because too muc…
mmathieum Aug 1, 2026
19c2460
PR comment
mmathieum Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions ...main/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,32 +121,40 @@ object GTFSRealTimeTripUpdatesProvider : MTLog.Loggable {
// private const val PRINT_ALL_RD_STOP_TIME_UPDATES = true // DEBUG

private fun GTripUpdate.isUseful(nowMs: Long, agencyTimeZone: KtTimeZone): Boolean {
val optTrip = optTrip ?: return false // not useful
optTrip.optScheduleRelationship?.let { scheduleRelationship ->
if (scheduleRelationship == GTDScheduleRelationship.DELETED
|| scheduleRelationship == GTDScheduleRelationship.CANCELED
) {
return true // useful (no max age)
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
optTimestampMs?.let { tuTimestamp ->
if (tuTimestamp + TRIP_UPDATE_MAX_AGE_MS < nowMs) {
MTLog.d(LOG_TAG, "isUseful() > IGNORE ${(nowMs - tuTimestamp).toDurationLog()} old: ${this.optTrip?.toStringExt(true)}")
MTLog.d(LOG_TAG, "isUseful() > IGNORE ${(nowMs - tuTimestamp).toDurationLog()} old: ${optTrip.toStringExt(true)}")
return false // not useful (too old to display)
}
}
val hasVehicleInfo = optVehicle?.let { it.hasId() || it.hasLabel() || it.hasLicensePlate() } == true
val startDateTimeOrFirstTimeMs: Long? = if (hasVehicleInfo) null else
(optTrip?.let { parseToDateTime(it.optStartDate, it.optStartTime, agencyTimeZone) }?.toMillis()
?: optTrip?.optModifiedTrip?.let { parseToDateTime(it.optStartDate, it.optStartTime, agencyTimeZone) }?.toMillis()
(optTrip.let { parseToDateTime(it.optStartDate, it.optStartTime, agencyTimeZone) }?.toMillis()
?: optTrip.optModifiedTrip?.let { parseToDateTime(it.optStartDate, it.optStartTime, agencyTimeZone) }?.toMillis()
?: optStopTimeUpdateList // not sorting because GTFS spec requires it to be already sorted & it's a fallback
?.firstOrNull { it.optDeparture?.hasTimeOrScheduledTime() == true || it.optArrival?.hasTimeOrScheduledTime() == true }
?.let {
it.optDeparture?.optTimeOrScheduledTimeMs ?: it.optArrival?.optTimeOrScheduledTimeMs
})
startDateTimeOrFirstTimeMs?.let { timeMs ->
if (nowMs + FUTURE_TRIP_UPDATE_MAX_DIFF_MS < timeMs) {
MTLog.d(LOG_TAG, "isUseful() > IGNORE ${((timeMs - nowMs)).toDurationLog()} in the future: ${this.optTrip?.toStringExt(true)}")
MTLog.d(LOG_TAG, "isUseful() > IGNORE ${((timeMs - nowMs)).toDurationLog()} in the future: ${optTrip.toStringExt(true)}")
return false // not useful (too far in advance to display)
}
}
if (hasDelay() || hasStopTimeUpdateList()) {
return true // useful (contains delay or STUs)
}
optTrip?.let { td -> // cannot match w/ static data
if (td.optScheduleRelationship?.let { it != GTDScheduleRelationship.SCHEDULED } == true) {
optTrip.optScheduleRelationship?.let { scheduleRelationship ->
if (scheduleRelationship != GTDScheduleRelationship.SCHEDULED) {
return true // useful
}
}
Expand Down
Loading