Add label for property sets dropdown (grid filter) field - #16970
Open
smg6511 wants to merge 2 commits into
Open
Conversation
Adds label for property sets combo to Prop Sets page and Elements' Properties tab
Make dropdown a little wider
Ibochkarev
approved these changes
Jul 7, 2026
Collaborator
Author
|
@mkschell - Hey Mike - This is an alternate implementation of a PR of Ivan's you previously approved. I closed that one in favor of this one and wanted you to take a look when you get a chance. Thx ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
See also #16896. This replacement PR uses the relatively new way of placing dropdown labels for grid toolbars (see the current Lexicons manager page)—putting them above the combo rather than beside it. This provides a cleaner appearance and conserves space in the toolbar. Since this same combo is also used in the Property Sets grid, a new method was added to the common base class to generate the combo there as well as in the Element Properties grids.
Note also that the arrangement of top toolbar buttons for the Property Sets grid now matches that of the Elements' Properties grids (with the dropdown on the right).
How to test
Related issue(s)/PR(s)
Replacement for PR #16896, which resolves #13901.
Compatibility notes
n/a
Breaking change assessment
n/a
Test coverage
n/a
Contributors
@Ibochkarev authored the initial solution.
AI tool use
None