Skip to content

Add label for property sets dropdown (grid filter) field - #16970

Open
smg6511 wants to merge 2 commits into
modxcms:3.xfrom
smg6511:3.x-pr-16896-alternate
Open

Add label for property sets dropdown (grid filter) field#16970
smg6511 wants to merge 2 commits into
modxcms:3.xfrom
smg6511:3.x-pr-16896-alternate

Conversation

@smg6511

@smg6511 smg6511 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

What changed and why

See also #16896. This replacement PR uses the relatively new way of placing dropdown labels for grid toolbars (see the current Lexicons manager page)—putting them above the combo rather than beside it. This provides a cleaner appearance and conserves space in the toolbar. Since this same combo is also used in the Property Sets grid, a new method was added to the common base class to generate the combo there as well as in the Element Properties grids.

Note also that the arrangement of top toolbar buttons for the Property Sets grid now matches that of the Elements' Properties grids (with the dropdown on the right).

How to test

  1. Create/edit various Elements, creating a property set or two in each (using Properties tab).
  2. Visit the main Property Sets page and experiment with adding and selecting prop sets there.
  3. In both cases, the prop set dropdown should have a label above and behave as expected.

Related issue(s)/PR(s)

Replacement for PR #16896, which resolves #13901.

Compatibility notes

n/a

Breaking change assessment

n/a

Test coverage

n/a

Contributors

@Ibochkarev authored the initial solution.

AI tool use

None

Adds label for property sets combo to Prop Sets page and Elements' Properties tab
Make dropdown a little wider
@Ibochkarev Ibochkarev added the requires build Grunt build is required for integration label Jul 29, 2026
@smg6511

smg6511 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@mkschell - Hey Mike - This is an alternate implementation of a PR of Ivan's you previously approved. I closed that one in favor of this one and wanted you to take a look when you get a chance. Thx ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires build Grunt build is required for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modx 3.x property set dropdown has no label

2 participants