fix(Workspace): Purge and remove transport files via package workspace paths - #16936
Open
Ibochkarev wants to merge 1 commit into
Open
fix(Workspace): Purge and remove transport files via package workspace paths#16936Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
…paths Resolve transport zip and unpacked directory paths from the package workspace (aligned with modTransportPackage transport layout), with fallback to core packages when no workspace row exists. Share filesystem cleanup via TransportPackageFilesystemTrait; add PHPUnit coverage for path resolution and purge/remove flows. Resolves modxcms#16929
Ibochkarev
force-pushed
the
fix/16929-package-purge-workspace-paths
branch
from
August 2, 2026 04:10
99ce539 to
1bb6c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Purge and Remove looked for transport zips and unpacked dirs under
core_path/packages/only. Manually uploaded packages (often without a provider) live under the workspacepath+packages/, so purge reported success while files remained (#16929).This PR adds
TransportPackageFilesystemTraitwithresolveTransportPaths()and shared zip/tree cleanup used by Purge and Remove.How to test
core/vendor/bin/phpunit -c _build/test/phpunit.xml --filter 'TransportPackageFilesystemTrait|PackagesPurgeRemove'Upload multiple versions of a package without a provider, run Purge Old Packages, confirm older signatures and workspace
packages/artifacts are gone.Related issue(s)/PR(s)
Resolves #16929
Compatibility notes
Package workspace and filesystem layout. Applies to uploads with and without a transport provider.
Breaking change assessment
No public API changes. Purge/remove now delete from resolved workspace paths; behavior change only for packages not stored under
core/packages/.Test coverage
PHPUnit for path resolution and purge/remove flows;
phpunit.xmlregistersTests/Processors/Workspace.Contributors
None beyond author.
AI tool use
Cursor helped normalize this PR description to the repository template.