Skip to content

add option to turn off https repo url to private recipes - #14

Open
lainosantos wants to merge 1 commit into
moay:masterfrom
lainosantos:turn_off_ssh_url_for_private_repos
Open

add option to turn off https repo url to private recipes#14
lainosantos wants to merge 1 commit into
moay:masterfrom
lainosantos:turn_off_ssh_url_for_private_repos

Conversation

@lainosantos

Copy link
Copy Markdown
Contributor

This PR is because sometimes privates git server has ssh url enabled, but not have https url enabled. Example: i'm using a private gitlab server with ssh enabled, but i not use https on this server.

Currentily, if a private recipes repo has a git ssh url, the recipes url is always https.

@lainosantos

Copy link
Copy Markdown
Contributor Author

This PR contains the changes fixs of #11 because the compiled js.

@lainosantos

Copy link
Copy Markdown
Contributor Author

Rebased after after #11 has been merged.

@moay

moay commented Jul 13, 2018

Copy link
Copy Markdown
Owner

Thanks for the cleanup. I thought on this issue and I think we should rethink the solution. It does not feel right to inject the information on https or not into the status report config only to have the variable available in the ui. A better solution would be to integrate this information into the git repo class and have it available there. The repo should have it's own propery baseHttpUrl or similar which should then contain the preparsed http(s) url (from the ssh url if needed).

What do you think on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants