Refactor NumberOfElements dtype dispatch - #4064
Merged
Merged
Conversation
This was referenced Aug 8, 2026
zcbenz
reviewed
Aug 8, 2026
| *out.data<complex64_t>() = static_cast<complex64_t>(numel); | ||
| break; | ||
| } | ||
| dispatch_all_types(out.dtype(), [&]<typename T>(type_identity<T>) { |
Member
There was a problem hiding this comment.
Thanks for doing the refactoring, though I'm not sure this is correct, it does not match other dispatch_all_types calls.
Contributor
Author
PhysicistJohn
force-pushed
the
dispatch/number-of-elements
branch
from
August 8, 2026 06:05
90f515b to
c278498
Compare
zcbenz
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the exhaustive dtype switch in
NumberOfElements::evalwith the existingdispatch_all_typesutility.This preserves the supported dtypes and existing conversion behavior while centralizing the type mapping. It follows the small-PR dtype-dispatch cleanup suggested in #3341.
Testing
pre-commitformatting checks