Fix DeviceType annotations for device and stream arguments - #4059
Open
XXXXRT666 wants to merge 4 commits into
Open
Fix DeviceType annotations for device and stream arguments#4059XXXXRT666 wants to merge 4 commits into
XXXXRT666 wants to merge 4 commits into
Conversation
zcbenz
reviewed
Aug 8, 2026
Contributor
Author
|
Another question: Do you prefer using Because nanobind automatically generates the |
Member
|
I don't really have a preference, but it feels more reasonable following what nanobind does. |
XXXXRT666
force-pushed
the
fix-device-type-stream-typing
branch
from
August 8, 2026 11:13
e9aa5d8 to
f9ec808
Compare
Contributor
Author
|
I think the CI is failing because the non-Metal export cannot recognize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
mx.cpuandmx.gpuareDeviceTypevalues. Nanobind accepts them at runtime through the existing implicit conversion fromDeviceTypetoDevice, but the generated Python stubs only exposedDevice. This caused type checkers to reject valid calls such as:This PR:
DeviceTypeas an explicitStreamOrDevicealternative.ThreadLocalStream, which is already accepted byStreamOrDevice, in those annotations.DeviceType-aware annotations to device and stream APIs that rely on nanobind's implicit conversion.Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes