Skip to content

Fix concurrent Metal kernel cache lookup #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 2 commits into from
Aug 8, 2026
Merged

Fix concurrent Metal kernel cache lookup #4043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e69f8bd
Fix concurrent Metal kernel cache lookup
Aug 7, 2026
2ad74fe
Remove unreliable test since the change is trivial
zcbenz Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mlx/backend/metal/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,9 +883,12 @@ MTL::ComputePipelineState* Device::get_kernel(
std::shared_lock lock(kernel_mtx_);

// Look for cached kernel
auto& kernel_map_ = library_kernels_[mtl_lib];
if (auto it = kernel_map_.find(kname); it != kernel_map_.end()) {
return it->second.get();
auto library_it = library_kernels_.find(mtl_lib);
if (library_it != library_kernels_.end()) {
auto kernel_it = library_it->second.find(kname);
if (kernel_it != library_it->second.end()) {
return kernel_it->second.get();
}
}
}
return get_kernel_(base_name, mtl_lib, kname, func_consts, linked_functions);
Expand Down
Loading