Use nix-env in ci - #81
Draft
mmlb wants to merge 5 commits into
Draft
Conversation
This is easier to use instead of having to go through nix-shell for each command. This also gets rid of the nix-shell in the shebang for formatters.sh so that we don't require nix-shell for its use. Different versions of tools will be caught by CI anyway so its fine to be lenient for users.
mmlb
force-pushed
the
use-nix-env-in-ci
branch
3 times, most recently
from
March 21, 2022 20:03
b0c40e2 to
b45a632
Compare
mmlb
marked this pull request as draft
March 21, 2022 20:37
mmlb
force-pushed
the
use-nix-env-in-ci
branch
6 times, most recently
from
March 22, 2022 18:57
23864e6 to
078a3d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I didn't think to use nix-env in CI until reading a snippet of someone doing so in a hackernew or mabye lobste.rs comment. This makes it so much nicer to use imo. I also got rid of the nix-shell in the formatters.sh shebang to make it more useful for users, no need to tie it to nix-shell and make it hard/unusable to people when CI will catch any diffs due to different tool versions.