Update from Library.Template - #390
Conversation
… (546) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Migrate coverage uploads to the supported Codecov CLI, verify its signed download, and propagate uploader failures to CI. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fix Codecov CLI publishing
Adds a -NoCoverage switch to dotnet-test-cloud.ps1 for both the MTP and VSTest code paths. Code coverage instrumentation can destabilize a test run, and when it does there is currently no way for a repo to keep running tests on the affected leg without hand-editing this script. Also collect a crash report alongside the crash dump, and restrict the dump to the heap. On Linux the native crash report is often the only way to identify the faulting thread and instruction when a test host dies of an access violation, and a heap dump is considerably smaller than the default full dump while still containing everything needed to analyze managed state. Finally, stop discarding crash dumps that have no TRX attachment copy. The previous filter kept a .dmp only when it appeared under a TRX 'In' directory, so on GitHub Actions -- which does not request a TRX report -- every crash dump was dropped from the uploaded artifacts, making test host crashes impossible to diagnose. The dumps are now de-duplicated by file name instead, which still avoids uploading the same dump twice on Azure Pipelines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add -NoCoverage switch and improve crash diagnostics
Merges Library.Template commit 2d53806. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 14 14
Lines 859 859
Branches 224 224
=======================================
Hits 669 669
Misses 126 126
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates repository tooling/scripts to align with the latest Library.Template microbuild, including a .NET SDK bump and improvements to test/coverage and artifact handling.
Changes:
- Bump required .NET SDK in
global.jsonto 10.0.400. - Switch Codecov integration to the newer Codecov CLI flow and harden signature verification behavior.
- Add an option to skip coverage collection during cloud-style test runs and improve dump/crash artifact selection to avoid duplicate uploads.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/publish-CodeCov.ps1 | Uses the Codecov CLI subcommand/args for uploading cobertura reports and fails fast on CLI errors. |
| tools/Install-DotNetSdk.ps1 | Adds a forced refresh path for cached release metadata when the requested version isn’t found. |
| tools/Get-CodeCovTool.ps1 | Updates download endpoints/paths for Codecov CLI and adds exit-code checks for gpg verification steps. |
| tools/dotnet-test-cloud.ps1 | Adds -NoCoverage switch and enhances crashdump/crash-report collection in MTP runs. |
| tools/artifacts/testResults.ps1 | Filters dump artifacts to avoid uploading duplicates when TRX attachments already include them. |
| global.json | Updates SDK version to 10.0.400. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
* Correct MTP -- forwarding with portable solution discovery. * Increase effective hang timeout to five minutes. * Batch all Codecov reports into one CLI invocation. * Preserve no-op behavior when no coverage exists.
Use ps1 splatting and exit instead of return
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0 (#553) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…emplate Specifically, this merges [ed6df17 from that repo](AArnott/Library.Template@ed6df17).
This reverts commit 663bdc9. We can't update to this for another several days.
…emplate Specifically, this merges [a853c38 from that repo](AArnott/Library.Template@a853c38).
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
tools/Get-CodeCovTool.ps1:14
- The script header/synopsis still describes downloading the Codecov “uploader tool”, but this change switches the download URLs to the Codecov CLI endpoint (
https://cli.codecov.io/...). Updating the synopsis avoids confusion when troubleshooting download/verification failures.
if ($IsMacOS) {
$codeCovUrl = "https://cli.codecov.io/latest/macos/codecov"
$toolName = 'codecov'
Updates from Library.Template microbuild commit 2d53806.
Validation could not run because this environment does not have the required .NET SDK 10.0.400 installed.