Skip to content

feat(packetparser): break down parsed packets and conntrack GCed entries by reason#2505

Open
mmckeen wants to merge 5 commits into
microsoft:mainfrom
mmckeen:reportReasonMetric
Open

feat(packetparser): break down parsed packets and conntrack GCed entries by reason#2505
mmckeen wants to merge 5 commits into
microsoft:mainfrom
mmckeen:reportReasonMetric

Conversation

@mmckeen

@mmckeen mmckeen commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

When debugging high levels of reported packets and drop events, it's useful to see the reasons why they were reported in order to properly tune sampling and other tunables.

It is the same for entries in the conntrack table that are GCed, the state the connection was in when GCed helps to tune for missed metrics.

Add a reason label to the current metrics to keep track of this.

Also adds visibility into conntrack bytes and connections missing a known direction (is_reply), useful to validate conntrack accuracy.

Related Issue

#1760

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Deployed in cluster, metrics show reasonable debugging into parsed packets.

Additional Notes

Along the way I found a bug where we never report the final packet during graceful TCP connection teardown, fix that as well.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@mmckeen
mmckeen marked this pull request as ready for review July 9, 2026 02:31
@mmckeen
mmckeen requested a review from a team as a code owner July 9, 2026 02:31
@mmckeen
mmckeen requested review from skosuri1 and timraymond July 9, 2026 02:31
@mmckeen
mmckeen force-pushed the reportReasonMetric branch from 7d23723 to 589eb8c Compare July 9, 2026 22:03
mmckeen added 5 commits July 15, 2026 09:44
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
Signed-off-by: Matthew McKeen <matthew.mckeen@fastly.com>
@mmckeen
mmckeen force-pushed the reportReasonMetric branch from 589eb8c to d261916 Compare July 15, 2026 15:44
@mmckeen mmckeen changed the title feat(packetparser): break down parsed packets and conntrack GCed entries by reason feat(packetparser): break down parsed packets and conntrack GCed entries by reason and lost packets/bytes Jul 19, 2026
@mmckeen
mmckeen force-pushed the reportReasonMetric branch from dc25974 to d261916 Compare July 20, 2026 00:45
@mmckeen mmckeen changed the title feat(packetparser): break down parsed packets and conntrack GCed entries by reason and lost packets/bytes feat(packetparser): break down parsed packets and conntrack GCed entries by reason Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant