Introduce reduce-scatter algo - #866
Open
Binyang Li (Binyang2014) wants to merge 17 commits into
Open
Conversation
Co-authored-by: Binyang2014 <9415966+Binyang2014@users.noreply.github.com>
Restore the previous FIFO protocol because the parity-based commit scheme stalls PortChannel proxy traffic on TP64. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60d476fd-fd9a-46ef-a7f8-c4d7fd05ef1d
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Binyang Li (Binyang2014)
marked this pull request as ready for review
August 11, 2026 17:24
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a hierarchical, packet-based multi-node ReduceScatter algorithm and supporting executor/API updates.
Changes:
- Adds and exports the ReduceScatter algorithm.
- Adds thread-block-group support to port packet transfers.
- Reuses cached execution contexts and limits IB registration to plans requiring IB.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/core/executor/executor.cc |
Improves context reuse and IB registration. |
python/mscclpp/language/channel.py |
Adds thread-block-group packet transfers. |
python/mscclpp/default_algos/reducescatter_multi_nodes.py |
Implements hierarchical ReduceScatter. |
python/mscclpp/default_algos/__init__.py |
Exports the new algorithm. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.