Sync eng/common directory with azure-sdk-tools for PR 16662 - #3221
Open
azure-sdk-automation[bot] wants to merge 1 commit into
Open
Sync eng/common directory with azure-sdk-tools for PR 16662#3221azure-sdk-automation[bot] wants to merge 1 commit into
azure-sdk-automation[bot] wants to merge 1 commit into
Conversation
azure-sdk-automation
Bot
requested review from
Chidozie Ononiwu (chidozieononiwu)
and
a lite review from Copilot
August 5, 2026 18:22
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Adds more flexible GitHub token export naming and improves robustness when resolving GitHub App installation IDs, and wires the new option through the Azure DevOps pipeline template.
Changes:
- Add
AlwaysUseOwnerSuffixto optionally always export tokens as<Prefix>_<Owner>, even for a single owner. - Harden installation listing/matching by introducing
Get-PropertyValueand tolerating differing response shapes (loginvsaccount.login), plus normalizeowner/repotoowner. - Wrap script execution in
Invoke-LoginToGitHuband skip invocation during Pester runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/scripts/login-to-github.ps1 | Adds owner-suffix option, response-shape tolerant installation lookup, and test-run guard. |
| eng/common/pipelines/templates/steps/login-to-github.yml | Passes new AlwaysUseOwnerSuffix argument; adjusts AzureCLI task configuration. |
Comment on lines
21
to
22
| - task: AzureCLI@2 | ||
| name: GenerateGitHubToken | ||
| displayName: "Login to GitHub" |
azure-sdk-automation
Bot
force-pushed
the
sync-eng-common-expandEngCommonWorkflow-16662
branch
2 times, most recently
from
August 5, 2026 22:26
b4ac891 to
ab44feb
Compare
azure-sdk-automation
Bot
force-pushed
the
sync-eng-common-expandEngCommonWorkflow-16662
branch
from
August 6, 2026 18:53
ab44feb to
f8b4cbe
Compare
Chidozie Ononiwu (chidozieononiwu)
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16662 See eng/common workflow