Enforce code styles in build - #3144
Open
Alan Zimmer (alzimmermsft) wants to merge 5 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Alan Zimmer (alzimmermsft)
requested review from
Jackson Weber (JacksonWeber),
Jonathan Cárdenas (JonathanCrd),
KarishmaGhiya,
Achyuth Maddala Sitaram (achyuth-ms),
Ankush Bindlish (ankushbindlish2),
Arun R (arunrab),
Connie Yau (conniey),
Daniel Dror (danield137),
Ji Wang (ericshape),
Jair Myree (jairmyree),
Jeremy Frosti (jeremyfrosti),
Krishnakumar R (KK) (kk-src),
Leighton Chen (lzchen),
Manvir Kaur (manvkaur),
meirloichter,
Michael (micha31r),
msalaman,
Philo (philon-msft),
paul1904 (prvavill),
Radhika Gupta (rads-1996),
Rajkumar Rangaraj (rajkumar-rangaraj),
Rebecca (Makar) McHugh (rebecca-makar),
Richard Park (richardpark-msft),
Kate Aisling (sharedferret),
vcolin7,
Varad Meru (vrdmr),
wuweng (weng5e),
Wolfgang De Salvador (wolfgang-desalvador) and
xiang17
as code owners
August 6, 2026 21:20
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes some changes to the build to enforce code style rules while building the project and enabling more diagnostics to be raised.
CancellationTokenparameters.Copyright (c) Microsoft Corporation.\nLicensed under the MIT License..usingdirectives to be outside ofnamespacescope.namespaceto be defined using file scoping instead of block scoping.namespaceto match folder structure.usingdirectives.creftypes to be declared inusingdirectives correctly.And fixed / suppressed (when valid to do so) all found issues due to the enforcement of the above.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline