Skip to content

feat: auto detect date_type when not provided#154

Open
laresbernardo wants to merge 4 commits into
microsoft:mainfrom
laresbernardo:main
Open

feat: auto detect date_type when not provided#154
laresbernardo wants to merge 4 commits into
microsoft:mainfrom
laresbernardo:main

Conversation

@laresbernardo

@laresbernardo laresbernardo commented Feb 26, 2024

Copy link
Copy Markdown

The user may or may not specify date_range. It's not needed given it can be calculated. By default I propose setting date_type = NULL so it happens automatically instead of the current obligatory input. This update doesn't break past versions usage.

@laresbernardo

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@mitokic

mitokic commented Mar 14, 2024

Copy link
Copy Markdown
Collaborator

Hey @laresbernardo thanks for the new feature! Can you please add a test in its own file in the test folder so we know it works for various types of data. Maybe using example data from the modeltime package.

@laresbernardo

Copy link
Copy Markdown
Author

Thanks for the feedback @mitokic Added new test.

@laresbernardo

Copy link
Copy Markdown
Author

Looking good to land? @mitokic

@mitokic

mitokic commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

@laresbernardo please review my comments and resolve them. Thanks!

@laresbernardo

Copy link
Copy Markdown
Author

Hi @mitokic I don't see any unresolved conversations. The tests are already implemented in commit 58d9e29. Am I missing something else? Have a nice weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants