Handle legacy local registry names - #248
Open
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Open
Handle legacy local registry names#248Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Renato L. de F. Cunha (renatolfc)
August 22, 2026 18:46
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the local-cluster management CLI cleanup path to handle a legacy Docker registry container name left behind by clusters created during the registry naming transition, aligning cleanup behavior with the historical container naming used by older clusters (Issue #166).
Changes:
- Update
destroy_old_registryto check for two historical registry container names and remove whichever exists. - Add a focused regression test covering the legacy-container-present cleanup path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vibe_core/vibe_core/cli/local.py |
Adjusts old-registry cleanup logic to look for two known historical container names. |
src/vibe_core/tests/test_local_service_images.py |
Adds a regression test validating legacy registry container cleanup behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1086
to
+1091
| for container_name in ( | ||
| f"{OLD_DEFAULT_CLUSTER_NAME}-registry", | ||
| f"k3d-{OLD_DEFAULT_CLUSTER_NAME}-registry.localhost", | ||
| ): | ||
| if docker.get(container_name): | ||
| docker.rm(container_name) |
Comment on lines
+299
to
+306
| assert local.destroy_old_registry(Mock(spec=OSArtifacts)) | ||
| assert docker.get.call_args_list == [ | ||
| call("farmvibes-ai-registry"), | ||
| call("k3d-farmvibes-ai-registry.localhost"), | ||
| ] | ||
| docker.rm.assert_called_once_with("farmvibes-ai-registry") | ||
|
|
||
|
|
Copilot started reviewing on behalf of
Renato L. de F. Cunha (renatolfc)
August 22, 2026 18:56
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clusters created during the registry naming transition can still have a
farmvibes-ai-registrycontainer, but update cleanup only looks fork3d-farmvibes-ai-registry.localhost. The update then leaves the legacy container behind or aborts.This PR checks only those two known historical names and removes whichever exists. It does not broaden deletion or change current registry setup. A focused regression covers the legacy-first path.
Closes #166.