Skip to content

Skip invalid Landsat QA asset - #247

Open
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
microsoft:mainfrom
renatolfc:fix/issue-116-landsat-qa
Open

Skip invalid Landsat QA asset#247
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
microsoft:mainfrom
renatolfc:fix/issue-116-landsat-qa

Conversation

@renatolfc

Copy link
Copy Markdown
Contributor

The Landsat downloader currently fetches the generic qa asset even though no workflow consumes it. For the scene reported in #116, Planetary Computer serves that asset as HTML while advertising it as a TIFF, so stacking fails before the usable qa_pixel mask is reached.

This PR removes only the unused qa key and keeps qa_pixel and qa_radsat. A focused regression checks that contract.

Closes #116.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Planetary Computer Landsat collection configuration to avoid downloading the generic qa asset, which can be served as invalid (HTML) content despite being advertised as a TIFF, causing downstream stacking failures (Issue #116).

Changes:

  • Remove the unused Landsat qa asset key from LandsatCollection.asset_keys.
  • Add a regression test to ensure qa is excluded and qa_pixel remains included.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vibe_lib/vibe_lib/planetary_computer.py Removes qa from Landsat asset download list to avoid invalid QA assets causing failures.
src/vibe_lib/tests/test_planetary_computer.py Adds a regression test asserting qa exclusion (and qa_pixel inclusion).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +7 to +9
def test_landsat_collection_excludes_non_raster_qa_asset():
assert "qa" not in LandsatCollection.asset_keys
assert "qa_pixel" in LandsatCollection.asset_keys

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in workflow execution "farm_ai/land_degradation/landsat_ndvi_trend"

2 participants