Skip invalid Landsat QA asset - #247
Open
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Open
Conversation
Copilot started reviewing on behalf of
Renato L. de F. Cunha (renatolfc)
August 22, 2026 18:46
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Planetary Computer Landsat collection configuration to avoid downloading the generic qa asset, which can be served as invalid (HTML) content despite being advertised as a TIFF, causing downstream stacking failures (Issue #116).
Changes:
- Remove the unused Landsat
qaasset key fromLandsatCollection.asset_keys. - Add a regression test to ensure
qais excluded andqa_pixelremains included.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vibe_lib/vibe_lib/planetary_computer.py | Removes qa from Landsat asset download list to avoid invalid QA assets causing failures. |
| src/vibe_lib/tests/test_planetary_computer.py | Adds a regression test asserting qa exclusion (and qa_pixel inclusion). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+9
| def test_landsat_collection_excludes_non_raster_qa_asset(): | ||
| assert "qa" not in LandsatCollection.asset_keys | ||
| assert "qa_pixel" in LandsatCollection.asset_keys |
Copilot started reviewing on behalf of
Renato L. de F. Cunha (renatolfc)
August 22, 2026 18:56
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Landsat downloader currently fetches the generic
qaasset even though no workflow consumes it. For the scene reported in #116, Planetary Computer serves that asset as HTML while advertising it as a TIFF, so stacking fails before the usableqa_pixelmask is reached.This PR removes only the unused
qakey and keepsqa_pixelandqa_radsat. A focused regression checks that contract.Closes #116.