Fix Helm provider v3 configuration - #246
Open
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Open
Fix Helm provider v3 configuration#246Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Renato L. de F. Cunha (renatolfc) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Renato L. de F. Cunha (renatolfc)
August 22, 2026 18:46
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Terraform Helm provider configuration in Kubernetes-related modules to be compatible with Helm provider v3+ (while still working for v2), and removes an invalid child-module backend declaration so backend configuration remains owned by root modules.
Changes:
- Removed
backend "kubernetes"from theservicesmodule to avoid “Backend configuration ignored” warnings when used as a child module. - Updated Helm provider configuration from the removed nested
kubernetes { ... }block syntax to the v3-compatiblekubernetes = { ... }object argument syntax in both affected modules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vibe_core/vibe_core/terraform/services/providers.tf | Removes child-module backend config and switches Helm provider Kubernetes config to object syntax. |
| src/vibe_core/vibe_core/terraform/aks/modules/kubernetes/providers.tf | Switches Helm provider Kubernetes config to object syntax for Helm provider v3 compatibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh Terraform initialization can select Helm provider v3 because the repository allows versions newer than 2.7.1, but the shared services and AKS Kubernetes modules still use the removed v2 nested
kubernetesblock. The services module also declares backend state even though it is consumed as a child module.This PR switches those active provider configurations to object syntax and leaves backend ownership with the root modules. Provider versions and deployment behavior are otherwise unchanged.
Closes #227.