Fix DragDropVisuals warnings that are treated as errors - #334
Open
Ratin Gao (RatinCN) wants to merge 1 commit into
Open
Fix DragDropVisuals warnings that are treated as errors#334Ratin Gao (RatinCN) wants to merge 1 commit into
Ratin Gao (RatinCN) wants to merge 1 commit into
Conversation
Zachary Northrup (zhuman)
approved these changes
Aug 23, 2024
Zachary Northrup (zhuman)
left a comment
Zachary Northrup (zhuman)
left a comment
There was a problem hiding this comment.
Thanks for the fixes!
Author
|
Chris Guzak (@ChrisGuzak) Okay to move on? |
Chris Guzak (ChrisGuzak)
approved these changes
Dec 1, 2025
| RECT rc; | ||
| GetWindowRect(hwndStatic, &rc); | ||
| const UINT dxdy = min(rc.right - rc.left, rc.bottom - rc.top); // make it square | ||
| LONG dxdy = min(rc.right - rc.left, rc.bottom - rc.top); // make it square |
There was a problem hiding this comment.
seems you can keep const, but the type change looks good.
Ratin Gao (RatinCN)
force-pushed
the
Fix_DragDropVisuals_Warning
branch
from
December 2, 2025 17:46
4adc71e to
bc52da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are warnings reported in newer Visual Studio and treated as errors in compile-time:
After this fix, the build success:
