Fix race condition in ProfileTiming iteration/action timeout tracking#740
Merged
nmalkapuram merged 2 commits intoJul 2, 2026
Merged
Conversation
added 2 commits
July 2, 2026 15:08
MonitorTimeoutAsync subscribed to the IterationEnd/ActionEnd events inside the background Task.Run body. When the profile action loop runs very quickly (e.g. a minimal execution interval), the first iteration(s)/action(s) could complete before the subscription was registered, causing an extra iteration/action to run beyond the requested count and intermittently failing ProfileExecutorHandlesExecutionTimingInstructionsCorrectly_ExplicitNumberIterationsScenario. Subscribe to the events synchronously before starting the background task, and correctly unsubscribe from ActionEnd (was IterationEnd) in the IndividualAction path. Bump version to 3.3.16.
…ProfileTimingRace # Conflicts: # VERSION
nmalkapuram
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonitorTimeoutAsync subscribed to the IterationEnd/ActionEnd events inside the background Task.Run body. When the profile action loop runs very quickly (e.g. a minimal execution interval), the first iteration(s)/action(s) could complete before the subscription was registered, causing an extra iteration/action to run beyond the requested count and intermittently failing ProfileExecutorHandlesExecutionTimingInstructionsCorrectly_ExplicitNumberIterationsScenario. Subscribe to the events synchronously before starting the background task, and correctly unsubscribe from ActionEnd (was IterationEnd) in the IndividualAction path. Bump version to 3.3.16.