[FIX]: Make Result.safe a derived property - #124
Merged
Conversation
Derive safe from status (status is SafetyStatus.SAFE) so it can never drift out of sync. Simplify resolve_as_attack/resolve_as_probe and XPIA observability adjustment to return SafetyStatus directly, and drop the redundant safe= argument from all Result constructions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5765e8db-a669-459f-8975-bc09b960608a
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
behnam-o
changed the title
spencrr
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Result.safeis now a computed@property(status is SafetyStatus.SAFE) instead of a stored dataclass field, so it can never drift out of sync withstatus.Since the invariant
safe == (status is SafetyStatus.SAFE)already held everywhere, this also removes the now-redundantsafevalue from the resolver plumbing:resolve_as_attack/resolve_as_probenow returnSafetyStatusdirectly instead of a(safe, status)tuple.XPIAExecution._adjust_for_observabilitytakes/returns onlySafetyStatus.Result(...)constructions drop thesafe=argument.Notes
result.safe,bool(result), andrepr(result)(still showssafe=...) behave exactly as before.extending-rampart.md,testing.md,pytest-integration.md).Testing
ruff check rampart tests— all checks passedpytest tests/unit— 616 passed