Add pink Standard Surface override baselines - #39
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds committed reference baselines for a Metashade “hot pink” diagnostic override of ND_standard_surface_surfaceshader, and updates CI/local environment configuration so Metashade-related reference comparisons point at the correct metashade_ref/libraries directory.
Changes:
- Added new MaterialX + GLSL baseline files for the
standard_surface_pinkoverride. - Updated the main GitHub Actions workflow to run
contrib/tests/test_render.py, Metashade’s owntests/mtlx/, andcontrib/tests/test_render_metashade.pyas distinct pytest steps. - Fixed
.envto include the missing/librariessuffix forMETASHADE_MTLX_PYTEST_REF_DIR.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contrib/tests/metashade_ref/libraries/standard_surface_pink/mx_metashade_standard_surface_surfaceshader_genglsl_impl.mtlx | Adds the .mtlx implementation entry that points to the generated GLSL override implementation. |
| contrib/tests/metashade_ref/libraries/standard_surface_pink/mx_metashade_standard_surface_surfaceshader_genglsl_impl.glsl | Adds the committed GLSL baseline implementing the “pink” diagnostic surfaceshader output. |
| .github/workflows/main.yml | Renames contrib test step labels and adds a dedicated pytest run for test_render_metashade.py. |
| .env | Updates METASHADE_MTLX_PYTEST_REF_DIR to target contrib/tests/metashade_ref/libraries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bump metashade submodule to pick up the Standard Surface override pipeline and the standard_surface_pink rename. Add GLSL baselines for the pink diagnostic override of ND_standard_surface_surfaceshader. Fix .env: METASHADE_MTLX_PYTEST_REF_DIR was missing /libraries. Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>
ppenenko
force-pushed
the
metashade/standard-surface-pink
branch
from
August 3, 2026 00:58
b04c67f to
83ae6e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR for metashade/metashade Standard Surface override pipeline (metashade/metashade#203) and pink rename (metashade/metashade#207).
Adds GLSL baselines for the pink diagnostic override of
ND_standard_surface_surfaceshader— a proof-of-concept that validates the Metashade override pipeline works end-to-end forsurfaceshadernodes.What changed
contrib/metashadeupdated to metashademain, picking up the Standard Surface pipeline and thestandard_surface_pinkrenamecontrib/tests/metashade_ref/libraries/standard_surface_pink/with the generated GLSL impl and.mtlxfor the pink SS override.env:METASHADE_MTLX_PYTEST_REF_DIRwas missing/librariessuffixDepends on
standard_surface_pink