Add Metashade override shader generation CI step - #38
Merged
Conversation
Run test_render_metashade.py --no-render in CI to verify that Metashade override libraries (passthru and broken_schlick) produce valid shaders when loaded as MaterialX implementation overrides. Also simplify CI step names to match the pytest commands they run. Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>
There was a problem hiding this comment.
Pull request overview
Adds a third headless contrib test step to the main GitHub Actions workflow to validate Metashade override shader generation, and renames existing contrib steps to align better with the pytest commands being run.
Changes:
- Renames the existing contrib render and Metashade workflow step names to “pytest …”.
- Adds a new contrib step to run
contrib/tests/test_render_metashade.py --no-renderin CI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -x -v | ||
|
|
||
| - name: Metashade Implementation Generation + RefDiffer | ||
| - name: pytest metashade.mtlx |
Comment on lines
+312
to
+315
| python -m pytest test_render_metashade.py | ||
| --no-render | ||
| --output-dir ${{ runner.temp }}/ci/renders | ||
| -x -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_render_metashade.py --no-render, verifying that Metashade override libraries (passthru and broken_schlick) produce valid shaders when loaded as MaterialX implementation overrides.This completes the three-step headless CI pipeline:
pytest test_render.py-- stdlib/adsk shader generation + RefDifferpytest metashade.mtlx-- Metashade implementation generation + RefDifferpytest test_render_metashade.py-- Metashade override shader generation (new)Test plan
pytest test_render_metashade.py --no-render --output-dir /tmp/ci_override -x -v-- 75 passed, 166 subtests passedLinux_GCC_14_Python313passes all three contrib test steps