Allow port toggle for unconnected ports - #305
Merged
Merged
Conversation
iljarotar
marked this pull request as draft
July 3, 2026 14:53
iljarotar
marked this pull request as ready for review
July 15, 2026 13:53
Contributor
Author
|
The tests are weird. On a switch update a mocked response is returned and the want is also the same switch as used for the response. Adding a wrong |
Gerrit91
approved these changes
Jul 17, 2026
…or-unconnected-ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
depends on metal-stack/metal-go#228
Restricting port toggle to the connected ports doesn't make sense. If a new machine is to be added and the port was down previously it should be possible to take it up. Otherwise the machine cannot register and hence the machine connection will not be known to the metal-api.
TODO