Add option for SONiC interface naming schema - #208
Open
iljarotar wants to merge 1 commit into
Open
Conversation
metal-robot
Bot
removed
the
triage
majst01
reviewed
Aug 7, 2026
Comment on lines
-12
to
+38
| type Core struct { | ||
| log *slog.Logger | ||
| logLevel string | ||
|
|
||
| cidr string | ||
| loopbackIP string | ||
| asn string | ||
| partitionID string | ||
| rackID string | ||
| roomID string | ||
| enableReconfigureSwitch bool | ||
| managementGateway string | ||
| additionalMgmtRoutes []string | ||
| additionalBridgePorts []string | ||
| additionalBridgeVIDs []string | ||
| spineUplinks []string | ||
| setSrcLoopback bool | ||
|
|
||
| nos switcher.NOS | ||
|
|
||
| driver metalgo.Client | ||
| eventServiceClient v1.EventServiceClient | ||
|
|
||
| metrics *metrics.Metrics | ||
|
|
||
| pxeVlanID uint16 | ||
|
|
||
| bgpNeighborStateFile string | ||
| } | ||
| type ( | ||
| Core struct { | ||
| log *slog.Logger | ||
| logLevel string | ||
|
|
||
| cidr string | ||
| loopbackIP string | ||
| asn string | ||
| partitionID string | ||
| rackID string | ||
| roomID string | ||
| enableReconfigureSwitch bool | ||
| managementGateway string | ||
| additionalMgmtRoutes []string | ||
| additionalBridgePorts []string | ||
| additionalBridgeVIDs []string | ||
| spineUplinks []string | ||
| setSrcLoopback bool | ||
|
|
||
| nos switcher.NOS | ||
|
|
||
| driver metalgo.Client | ||
| eventServiceClient v1.EventServiceClient | ||
|
|
||
| metrics *metrics.Metrics | ||
|
|
||
| pxeVlanID uint16 |
Contributor
There was a problem hiding this comment.
Maybe carry this changes in a PR upfront to make this PR easier to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The naming schema of SONiC interfaces in combination with what messages it sends via LLDP is causing problems when trying to adopt different distributions. Read the readme changes for more details.