by ironsizide: Add CHANGELOG.txt, Update README.txt - #5
Open
ironsizide wants to merge 5 commits into
Open
Conversation
aaronbauman
reviewed
Feb 27, 2019
cwcorrigan
reviewed
Feb 27, 2019
Contributor
Author
|
Idle thought: while I'm here, thoughts on converting README.txt to README.md? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Change log is very much a work in progress, and is generated using the drush command from commit messages tracking the 8.x-3.x tag and the origin/8.x-4.x branch. I'll manually change it to the issues once we have a complete set of changes finalized.
The Readme has been updated with the config settings changes in settings.php, and upgrade guide for JWT auth, and a revised module list. The config settings are pretty awkward at this point and I'm not sure what part of them belong in settings at this pointl, particularly with the secret key setting. There's nothing to risky here in having the key's machine name, but I thinking the same key will be used in all environments, so storing different settings across environment for this one settings may not be necessary.