Skip to content

Support blur subtitle with interaction - #1558

Closed
BilderLoong wants to merge 2 commits into
mengxi-ream:mainfrom
BilderLoong:feature/blur_subtitle
Closed

Support blur subtitle with interaction#1558
BilderLoong wants to merge 2 commits into
mengxi-ream:mainfrom
BilderLoong:feature/blur_subtitle

Conversation

@BilderLoong

@BilderLoong BilderLoong commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Type of Changes

  • ✨ New feature (feat)
  • 🐛 Bug fix (fix)
  • 📝 Documentation change (docs)
  • 💄 UI/style change (style)
  • ♻️ Code refactoring (refactor)
  • ⚡ Performance improvement (perf)
  • ✅ Test related (test)
  • 🔧 Build or dependencies update (build)
  • 🔄 CI/CD related (ci)
  • 🌐 Internationalization (i18n)
  • 🧠 AI model related (ai)
  • 🔄 Revert a previous commit (revert)
  • 📦 Other changes that do not modify src or test files (chore)

Description

Draft PR for the blur subtitle interaction. Use to demonstrate for the #1448

Related Issue

#1554

How Has This Been Tested?

  • Added unit tests
  • Verified through manual testing

Screenshots

Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly if necessary
  • My code follows the code style of this project
  • My changes do not break existing functionality
  • If my code was generated by AI, I have proofread and improved it as necessary.

Additional Information

@changeset-bot

changeset-bot Bot commented May 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3d0dcb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added contrib-trust:new PR author trust score is 0-29. needs-maintainer-review Contributor trust automation recommends maintainer review. labels May 20, 2026
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Contributor trust score

14/100 — New contributor

This score estimates contributor familiarity with mengxi-ream/read-frog using public GitHub signals. It is advisory only and does not block merges automatically.

Outcome

Score breakdown

Dimension Score Signals
Repo familiarity 0/35 commits in repo, merged PRs, reviews
Community standing 6/25 account age, followers, repo role
OSS influence 3/20 stars on owned non-fork repositories
PR track record 5/20 merge rate across resolved PRs in this repo

Signals used

  • Repo commits: 0 (author commits reachable from the repository default branch)
  • Repo PR history: merged 0, open 1, closed-unmerged 0
  • Repo reviews: 0
  • PR changed lines: 125 (+98 / -27)
  • Repo permission: read
  • Followers: 3
  • Account age: 90 months
  • Owned non-fork repos considered: max 1, total 2 (BilderLoong/yomitan-dictionary (1), BilderLoong/dotfiles (1), BilderLoong/private-collection-wraper (0), BilderLoong/Transcribe-Audio (0), BilderLoong/test (0), BilderLoong/LLM-for-language-learning (0), BilderLoong/storybook-demo (0), BilderLoong/audiobook-player (0), BilderLoong/react-test-playground (0), BilderLoong/playground (0), BilderLoong/devSNS (0), BilderLoong/mini_RESTful_API (0), BilderLoong/react-todo-list (0), BilderLoong/firebase_test (0), BilderLoong/Tiktok-clone (0), BilderLoong/Lisp_exercise (0), BilderLoong/yomisan (0), BilderLoong/tic-tac-toe-game (0), BilderLoong/ScreepsAPIDocFormater (0), BilderLoong/reactTolist (0))

Policy

  • Low-score review threshold: < 30
  • Auto-close: score < 20 and changed lines > 1000
  • Policy version: v1.1

Updated automatically when the PR changes or when a maintainer reruns the workflow.

@BilderLoong
BilderLoong marked this pull request as draft May 20, 2026 13:47
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d0dcb5d2a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/entrypoints/subtitles.content/ui/subtitles-view.tsx
const subtitle = useAtomValue(currentSubtitleAtom)
const { style } = useAtomValue(configFieldsAtomMap.videoSubtitles)
const { displayMode, translationPosition, container } = style
const { blurMain, blurTranslation } = computeSubtitleBlurState(subtitleBlurModeSchema.enum.blurAll, useBlurKey())

@chatgpt-codex-connector chatgpt-codex-connector Bot May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Respect configured subtitle blur mode

SubtitlesContent computes blur state with subtitleBlurModeSchema.enum.blurAll unconditionally, so the new videoSubtitles.blurMode config (including the default blurOnlyTranslation) is never applied at runtime. This makes persisted/user-selected blur behavior impossible and forces all users into blur-all cycling logic regardless of config.

Useful? React with 👍 / 👎.

Comment thread src/entrypoints/subtitles.content/ui/subtitles-view.tsx
}

function handler(e: KeyboardEvent) {
if (e.key !== "e" || ["INPUT", "TEXTAREA"].includes((e.target as HTMLElement).tagName)) {

@chatgpt-codex-connector chatgpt-codex-connector Bot May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid hijacking key presses in contenteditable fields

The keydown filter only exempts INPUT and TEXTAREA, so when focus is in rich-text editors (contenteditable elements), pressing e still triggers blur toggling and preventDefault(). In pages like comment/chat editors this blocks typing the letter e while subtitles are active.

Useful? React with 👍 / 👎.

@BilderLoong BilderLoong mentioned this pull request May 20, 2026
Open
20 tasks
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for 14 days and is now marked as stale.
It will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions Bot added the Stale label Jun 4, 2026
@mengxi-ream

mengxi-ream commented Jun 11, 2026

Copy link
Copy Markdown
Owner

等待 @taiiiyang 和 @oskkas 一起完成 #1448

所以这个 PR 我就先关了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

contrib-trust:new PR author trust score is 0-29. needs-maintainer-review Contributor trust automation recommends maintainer review. Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BilderLoong @mengxi-ream