feat: strikethrough original dest/origin stations when changed - #562
Open
jkap wants to merge 1 commit into
Open
Conversation
Includes DB changes, OCS message handling changes, and UI changes
mathcolo
reviewed
Aug 5, 2026
Comment on lines
+314
to
+315
| destination_station: | ||
| fragment("COALESCE(?, EXCLUDED.destination_station)", trip.destination_station), |
Collaborator
There was a problem hiding this comment.
question: is setting destination_station on a TSCH DST conflict a no-op? i.e. can this line be left out, or does the set have to cover all columns?
Contributor
Author
There was a problem hiding this comment.
we might be able to get away with leaving it out. let me do some testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes DB changes, OCS message handling changes, and UI changes
Asana Task: 🍫 Strikethrough departure/arrival in orbit sidebar when changed
Does not include accurate design since that's dependent on the tailwind and sidebar redesign work.
Checklist
(x)Light & dark mode(x)Desktop & mobile sizes( )Chromium(x)Firefox( )Safari(x)Commits free of internal data(x)PR description free of internal data(x)Logging free of internal data(x)Has tests( )Doesn't need tests( )Tests deferred (with justification)( )Okayed the plan for the feature (e.g. the design files, or the Asana task)( )Reviewed the feature as implemented (e.g. on dev-green, or saw screenshots)( )No review needed