performance: Move API calls out of render and into subway_status - #3408
Draft
jlucytan wants to merge 4 commits into
Draft
performance: Move API calls out of render and into subway_status#3408jlucytan wants to merge 4 commits into
jlucytan wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📈 🛠️ [Subway Status] Move API calls / stop-loading out of component-rendering
Implementation
Moves
affected_stopsandendpoint_stopsout ofstatus_row_headingand intosubway_statusso there are fewer API calls at render time, and the data is cached.Known issue: Planned Work doesn't correctly display subheading. Will need to add subheading_data to
disruptions.exScreenshots
Should have no visual changes.
Old flamegraph:
New flamegraph:
How to test
Homepage and alerts page appearance should not change between this branch and prod.