QF | FunctionClauseError: no function clause matching in Services.Repo.handle_response/1 - #3407
Open
lvachon1 wants to merge 6 commits into
Open
QF | FunctionClauseError: no function clause matching in Services.Repo.handle_response/1#3407lvachon1 wants to merge 6 commits into
lvachon1 wants to merge 6 commits into
Conversation
…/github.com/mbta/dotcom into lev/fix/services_repo_handle_response_error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: QF | FunctionClauseError: no function clause matching in Services.Repo.handle_response/1
Implementation
Made one of the error handling versions this functions a bit more generic so that it can handle any type of error with a reason. Sentry saw
{:error, %Finch.TransportError{reason: :timeout, source: %Mint.TransportError{reason: :timeout}}}which didn't quite match the existing pattern. I don't see any reason to be overly specific about what kind error it is, just that is has a reason that we can show.Screenshots
N/A
How to test
Unit tests