Skip to content

Remove stale maxmind-db entry from .gitmodules - #469

Merged
oschwald merged 1 commit into
mainfrom
claude/remove-stale-gitmodules-entry
Aug 5, 2026
Merged

Remove stale maxmind-db entry from .gitmodules#469
oschwald merged 1 commit into
mainfrom
claude/remove-stale-gitmodules-entry

Conversation

@horgh

@horgh horgh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Problem

The Dependabot Failure Watcher failed (run 31018162189) because the first scheduled gitsubmodule update run (run 30941152746, enabled in #465) aborted with:

dependency_file_not_found: "maxmind-db not found", file-path: "maxmind-db"

.gitmodules declared three submodules, but the repo tree only contains two gitlinks (t/libtap and t/maxmind-db). Commit 5f499c1 (2014) moved the submodule from maxmind-db to t/maxmind-db but left the old [submodule "maxmind-db"] stanza behind. Dependabot fetches each declared path via the GitHub contents API; GET /contents/maxmind-db returns 404, aborting the whole job.

Fix

Remove the stale stanza. Nothing references a top-level maxmind-db checkout (the t/Makefile.am reference is relative to t/).

Verification

Replicating Dependabot's per-path contents API lookup (the exact request that failed in the job log):

On main (5886ccf):

maxmind-db   -> HTTP 404   <- aborts the Dependabot job
t/libtap     -> 200
t/maxmind-db -> 200

On this branch (8c33c0c):

t/libtap     -> 200
t/maxmind-db -> 200

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed obsolete submodule configuration.

Commit 5f499c1 (2014) moved the maxmind-db submodule to t/maxmind-db
and deleted the gitlink at the top-level path, but left the old
[submodule "maxmind-db"] stanza in .gitmodules.

This was harmless until Dependabot gitsubmodule updates were enabled
(8161529). Dependabot parses .gitmodules and fetches each declared
path via the GitHub contents API; GET /contents/maxmind-db returns
404, so every update run aborts with dependency_file_not_found,
which in turn trips the Dependabot Failure Watcher.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 5, 2026 18:59
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8337d205-532a-445d-bca9-dbb0ba56b3eb

📥 Commits

Reviewing files that changed from the base of the PR and between 5886ccf and 8c33c0c.

📒 Files selected for processing (1)
  • .gitmodules
💤 Files with no reviewable changes (1)
  • .gitmodules

📝 Walkthrough

Walkthrough

Removed the maxmind-db submodule configuration from .gitmodules. The t/maxmind-db entry remains.

Changes

Cohort / File(s) Summary
Submodule configuration
.gitmodules
Removed the maxmind-db configuration entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

Poem

A rabbit checks the module nest,
One entry hops away.
The test database stays put,
Safe in its burrowed stay.
.gitmodules is clean today.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the stale maxmind-db entry from .gitmodules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/remove-stale-gitmodules-entry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a stale maxmind-db submodule entry from .gitmodules that no longer exists in the repository tree, which was causing Dependabot’s git submodule update job to abort when it attempted to fetch maxmind-db via the GitHub Contents API.

Changes:

  • Removed the obsolete [submodule "maxmind-db"] stanza whose path = maxmind-db no longer exists.
  • Leaves the active submodules (t/libtap and t/maxmind-db) unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@oschwald
oschwald merged commit 56402c6 into main Aug 5, 2026
37 checks passed
@oschwald
oschwald deleted the claude/remove-stale-gitmodules-entry branch August 5, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants