Retry on Faraday::ConnectionFailed (DNS/TCP transient errors) v0.5.3#42
Merged
Conversation
Adds Faraday::ConnectionFailed to the transient-error retry block so DNS resolution failures and TCP connection errors are retried with the same exponential backoff as 502/503/504, instead of crashing the import. Bumps version to 0.5.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Faraday::ConnectionFailed(DNS resolution failure, TCP connection refused) was crashing import jobs instead of retrying. This adds it to the existing transient-error rescue block alongside 502/503/504/429, so it retries with the same exponential backoff (2s → 4s → raises).Example error that is now retried:
Bumps version to 0.5.3, updates all Gemfile locks.
Test plan
STUB_STACK=elasticsearch-7.17.0 BUNDLE_GEMFILE=gemfiles/Gemfile.elasticsearch-7.x bundle exec rspec spec/esse/import/bulk_spec.rb— 16 examples, 0 failures