Tickets/osw 1886#1058
Open
wvreeven wants to merge 2 commits into
Open
Conversation
wvreeven
force-pushed
the
tickets/OSW-1886
branch
2 times, most recently
from
09336c5 to
fdd0a82
Compare
teweitsai
reviewed
Mar 5, 2026
wvreeven
force-pushed
the
tickets/OSW-1886
branch
from
fdd0a82 to
3f83ee8
Compare
tribeiro
approved these changes
Mar 6, 2026
tribeiro
left a comment
tribeiro
left a comment
Member
There was a problem hiding this comment.
Looks good. The bulk of the changes here come from the adoption of ruff, the actual relevant changes are pretty small. Thanks for splitting it up in the different commits.
I don't know if here or in salobj but it would be good to have a test for overflow for int and float, just to make sure we are actually capturing what we intended to capture.
wvreeven
force-pushed
the
tickets/OSW-1886
branch
from
3f83ee8 to
0ef25a0
Compare
wvreeven
force-pushed
the
tickets/OSW-1886
branch
from
0ef25a0 to
9d4e2f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.