Fix HTML generation for RBS constants without values - #1693
Closed
oiahoon wants to merge 1 commit into
Closed
Conversation
Owner
|
A very oddly timed duplicate of #1692. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1686.
RBS constant declarations carry a type but no Ruby source value. Render a missing constant value as empty content so the default module template can generate the class page instead of raising
NoMethodError.This includes direct helper coverage, a template-level RBS regression, and the main changelog entry.
Validation
bundle exec rspec spec/handlers/rbs/constant_handler_spec.rb spec/templates/helpers/method_helper_spec.rb spec/templates/module_spec.rb— 26 examples, 0 failuresbundle exec rake— 2,786 examples, 0 failures; documentation check passedFoo.htmlwithBARand an empty source-value blocknpx --yes @biomejs/biome format— passednpx --yes @biomejs/biome lint— passed with four existing warnings in unchanged JavaScript filesgit diff --check— passedCompleted Tasks
bundle exec rakelocally (if code is attached to PR).