fix(core): reformat union types per prettier 3.9.5#1366
Conversation
Prettier 3.9.5 (#1337) changed how it wraps short union types, but the affected files weren't reformatted at the time, leaving lint broken on main since that merge.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
|
@thomasyuill-livekit I've also got a WIP fix for this in #1355 which I'm trying to get pass right now. If you get this fully fixed in here feel free to merge this first and I'll rebase it out of the dependency bump one |
Prettier 3.9.5 (#1337) changed how it wraps short union types, but the affected files weren't reformatted at the time, leaving lint broken on main since that merge.
Same prettier 3.9.5 (#1337) union-type wrapping change, unfixed in tooling/api-documenter, breaking the format:check CI job on main.
api-extractor flags the useEvents generic constraint as an API change after the prettier 3.9.5 reformat added parentheses around the conditional type; regenerate the snapshot to match.
|
@1egoman looks like we've got this passing |
2 participants
Issue
No linked Linear ticket.
Overview
CI's lint step has been broken on
mainsince #1337 (prettier bump to 3.9.5) — the new prettier version collapses short multi-line union types onto one line, but the three affected files were never reformatted, so everytestCI run since then fails at the ESLint/prettier step in@livekit/components-core.Summary of changes
Whitespace-only
prettier --writeon the three flagged files:packages/core/src/components/chat.tspackages/core/src/messages/types.tspackages/core/src/types.tsNo behavioral changes.
Testing
pnpm --filter @livekit/components-core lint— passes (previously failed with 3prettier/prettiererrors)